From 85668ffaf87cb75754e020fda399da663a814519 Mon Sep 17 00:00:00 2001 From: Dillon-Brown <dillon.brown@salesagility.com> Date: Mon, 3 Sep 2018 11:57:06 +0100 Subject: [PATCH] Fixed review comment: Function visiblility --- include/generic/SugarWidgets/SugarWidgetSubPanelConcat.php | 2 +- .../generic/SugarWidgets/SugarWidgetSubPanelEditRoleButton.php | 2 +- modules/Opportunities/Opportunity.php | 2 +- modules/ProjectTask/ProjectTask.php | 2 +- modules/ProspectLists/ProspectList.php | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/generic/SugarWidgets/SugarWidgetSubPanelConcat.php b/include/generic/SugarWidgets/SugarWidgetSubPanelConcat.php index c8ce2d6ddc..1556509f55 100755 --- a/include/generic/SugarWidgets/SugarWidgetSubPanelConcat.php +++ b/include/generic/SugarWidgets/SugarWidgetSubPanelConcat.php @@ -48,7 +48,7 @@ if (!defined('sugarEntry') || !sugarEntry) { class SugarWidgetSubPanelConcat extends SugarWidgetField { - function displayList($layout_def) + public function displayList($layout_def) { $value=''; if (isset($layout_def['source']) and is_array($layout_def['source']) and isset($layout_def['fields']) and is_array($layout_def['fields'])) { diff --git a/include/generic/SugarWidgets/SugarWidgetSubPanelEditRoleButton.php b/include/generic/SugarWidgets/SugarWidgetSubPanelEditRoleButton.php index 25d54c9a37..ecfe808ec6 100755 --- a/include/generic/SugarWidgets/SugarWidgetSubPanelEditRoleButton.php +++ b/include/generic/SugarWidgets/SugarWidgetSubPanelEditRoleButton.php @@ -53,7 +53,7 @@ class SugarWidgetSubPanelEditRoleButton extends SugarWidgetField return ' '; } - function displayList($layout_def) + public function displayList($layout_def) { global $app_strings; global $subpanel_item_count; diff --git a/modules/Opportunities/Opportunity.php b/modules/Opportunities/Opportunity.php index a60651399e..84b7c95c43 100755 --- a/modules/Opportunities/Opportunity.php +++ b/modules/Opportunities/Opportunity.php @@ -335,7 +335,7 @@ class Opportunity extends SugarBean builds a generic search based on the query string using or do not include any $this-> because this is called on without having the class instantiated */ - function build_generic_where_clause ($the_query_string) { + public function build_generic_where_clause ($the_query_string) { $where_clauses = Array(); $the_query_string = DBManagerFactory::getInstance()->quote($the_query_string); array_push($where_clauses, "opportunities.name like '$the_query_string%'"); diff --git a/modules/ProjectTask/ProjectTask.php b/modules/ProjectTask/ProjectTask.php index dc7168a160..8bffa98ae2 100755 --- a/modules/ProjectTask/ProjectTask.php +++ b/modules/ProjectTask/ProjectTask.php @@ -258,7 +258,7 @@ class ProjectTask extends SugarBean /* * */ - function build_generic_where_clause ($the_query_string) + public function build_generic_where_clause ($the_query_string) { $where_clauses = array(); $the_query_string = DBManagerFactory::getInstance()->quote($the_query_string); diff --git a/modules/ProspectLists/ProspectList.php b/modules/ProspectLists/ProspectList.php index fdadaf884a..878c1a5211 100755 --- a/modules/ProspectLists/ProspectList.php +++ b/modules/ProspectLists/ProspectList.php @@ -390,7 +390,7 @@ FROM prospect_lists_prospects plp } - function get_list_view_data(){ + public function get_list_view_data(){ $temp_array = $this->get_list_view_array(); $temp_array["ENTRY_COUNT"] = $this->get_entry_count(); return $temp_array;