archive/nextcloud_server
0
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2025-05-03 21:40:31 +00:00
Code Issues Projects Releases Wiki Activity
nextcloud_server/tests/lib/Files/Storage
History
Exact
Louis Chemineau 9bed21a8d7 fix: Transfer ownership with S3 as primary 
When using S3 as primary storage, transferring ownership with the `--move` option fail with the following error:

`SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '8-45b963397aa40d4a0063e0d85e4fe7a1' for key 'fs_storage_path_hash'`

The `--move` option moves the entire home folder from one account to another.
The error means that the move failed because the destination folder already exist in `oc_filecache`.

- With S3 as primary storage, folders only exists as entries in `oc_filecache`.
- With S3 as primary storage, `moveFromStorage(...)` only moves the cache entry, as nothing needs to be moved on disk. This cache move does not delete potentially pre-existing destination folder.
- With Local storage, `moveFromStorage(...)` calls `rename(...)` which delete pre-existing folder.

- `transfer(...)`: 687a4d9ac7/apps/files/lib/Service/OwnershipTransferService.php (L112)
- `oneTimeUserSetup(...)`: 687a4d9ac7/lib/private/Files/SetupManager.php (L261-L262)
- `mkdir(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L91-L135)
- `moveFromStorage(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L635-L636)

Delete pre-existing folder in `moveFromStorage(...)`

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-04-16 16:18:42 +02:00
..
Wrapper fix(files): Do not array access null value 2025-01-28 20:51:42 +01:00
CommonTest.php refactor: Migrate filename validation logic from Storage to FilenameValidator 2024-07-16 12:49:09 +02:00
CopyDirectoryTest.php chore: Add SPDX header 2024-05-13 17:41:36 +02:00
HomeTest.php chore: Add SPDX header 2024-05-13 17:41:36 +02:00
LocalTest.php test: add test for nested jail cross-storage move 2024-10-29 15:02:49 +00:00
Storage.php fix: Clean-up some remaining readdir calls with undesirable false evaluation potential 2024-11-13 09:11:17 +05:30
StorageFactoryTest.php chore: Add SPDX header 2024-05-13 17:41:36 +02:00
StoragesTest.php fix: Transfer ownership with S3 as primary 2025-04-16 16:18:42 +02:00