archive/nextcloud_server
0
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2025-05-03 13:30:32 +00:00
Code Issues Projects Releases Wiki Activity
nextcloud_server/tests/lib/Files/Storage
History
Exact
Louis Chemineau 8fdf2a7eae fix: Transfer ownership with S3 as primary 
When using S3 as primary storage, transferring ownership with the `--move` option fail with the following error:

`SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '8-45b963397aa40d4a0063e0d85e4fe7a1' for key 'fs_storage_path_hash'`

The `--move` option moves the entire home folder from one account to another.
The error means that the move failed because the destination folder already exist in `oc_filecache`.

- With S3 as primary storage, folders only exists as entries in `oc_filecache`.
- With S3 as primary storage, `moveFromStorage(...)` only moves the cache entry, as nothing needs to be moved on disk. This cache move does not delete potentially pre-existing destination folder.
- With Local storage, `moveFromStorage(...)` calls `rename(...)` which delete pre-existing folder.

- `transfer(...)`: 687a4d9ac7/apps/files/lib/Service/OwnershipTransferService.php (L112)
- `oneTimeUserSetup(...)`: 687a4d9ac7/lib/private/Files/SetupManager.php (L261-L262)
- `mkdir(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L91-L135)
- `moveFromStorage(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L635-L636)

Delete pre-existing folder in `moveFromStorage(...)`

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-04-01 13:53:56 +02:00
..
Wrapper fix: Harden files scanner for invalid null access 2025-01-28 20:08:46 +01:00
CommonTest.php refactor: Add void return type to PHPUnit test methods 2024-09-15 22:32:31 +02:00
CopyDirectoryTest.php refactor(Storage): Make all parameter types strong types 2024-10-07 15:00:05 +02:00
HomeTest.php refactor: Add void return type to PHPUnit test methods 2024-09-15 22:32:31 +02:00
LocalTest.php Merge pull request #47847 from nextcloud/fix-copying-or-moving-from-shared-groupfolders 2024-10-29 11:33:12 +01:00
Storage.php fix: Fix other uses of removed Storage interface 2024-09-16 18:11:36 +02:00
StorageFactoryTest.php refactor(Storage): Align all Storage constructors 2024-10-23 13:24:18 +02:00
StoragesTest.php fix: Transfer ownership with S3 as primary 2025-04-01 13:53:56 +02:00