0
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2025-05-20 21:20:14 +00:00
nextcloud_server/apps/dav/lib/DAV/Sharing/SharingService.php
Daniel Kesselberg c05d3fdb2e
fix(caldav): prevent unshare entry creation for owner unsharing
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- https://github.com/nextcloud/server/pull/43117
- https://github.com/nextcloud/server/pull/47737

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-14 09:03:32 +02:00

53 lines
1.7 KiB
PHP

<?php
declare(strict_types=1);
/**
* SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
namespace OCA\DAV\DAV\Sharing;
abstract class SharingService {
protected string $resourceType = '';
public function __construct(
protected SharingMapper $mapper,
) {
}
public function getResourceType(): string {
return $this->resourceType;
}
public function shareWith(int $resourceId, string $principal, int $access): void {
// remove the share if it already exists
$this->mapper->deleteShare($resourceId, $this->getResourceType(), $principal);
$this->mapper->share($resourceId, $this->getResourceType(), $access, $principal);
}
public function unshare(int $resourceId, string $principal): void {
$this->mapper->unshare($resourceId, $this->getResourceType(), $principal);
}
public function deleteShare(int $resourceId, string $principal): void {
$this->mapper->deleteShare($resourceId, $this->getResourceType(), $principal);
}
public function deleteAllShares(int $resourceId): void {
$this->mapper->deleteAllShares($resourceId, $this->getResourceType());
}
public function deleteAllSharesByUser(string $principaluri): void {
$this->mapper->deleteAllSharesByUser($principaluri, $this->getResourceType());
}
public function getShares(int $resourceId): array {
return $this->mapper->getSharesForId($resourceId, $this->getResourceType());
}
public function getUnshares(int $resourceId): array {
return $this->mapper->getUnsharesForId($resourceId, $this->getResourceType());
}
public function getSharesForIds(array $resourceIds): array {
return $this->mapper->getSharesForIds($resourceIds, $this->getResourceType());
}
}