archive/kevinpapst_kimai2
0
0
Fork 0
mirror of https://github.com/kevinpapst/kimai2.git synced 2025-04-07 22:45:50 +00:00
Code Issues Projects Releases Wiki Activity

do not trigger export validation on new timesheets

Browse source
This commit is contained in:
Kevin Papst 2022-01-20 16:57:00 +01:00
parent c040af8983
commit 42e6b7818b
2 changed files with 21 additions and 2 deletions
src/Validator/Constraints
TimesheetExportedValidator.php
tests/Validator/Constraints
TimesheetExportedValidatorTest.php

4
src/Validator/Constraints/TimesheetExportedValidator.php
View file

@ -38,6 +38,10 @@ final class TimesheetExportedValidator extends ConstraintValidator
throw new UnexpectedTypeException($timesheet, TimesheetEntity::class);
}
if ($timesheet->getId() === null) {
return;
}
if (!$timesheet->isExported()) {
return;
}

19
tests/Validator/Constraints/TimesheetExportedValidatorTest.php
View file

@ -66,8 +66,9 @@ class TimesheetExportedValidatorTest extends ConstraintValidatorTestCase
$this->validator = $this->createMyValidator(false);
$this->validator->initialize($this->context);
$timesheet = new Timesheet();
$timesheet->setExported(true);
$timesheet = $this->createMock(Timesheet::class);
$timesheet->method('isExported')->willReturn(true);
$timesheet->method('getId')->willReturn(1);
$this->validator->validate($timesheet, new TimesheetExported());
@ -77,6 +78,20 @@ class TimesheetExportedValidatorTest extends ConstraintValidatorTestCase
->assertRaised();
}
public function testNotTriggersOnNewTimesheet()
{
$this->validator = $this->createMyValidator(false);
$this->validator->initialize($this->context);
$timesheet = $this->createMock(Timesheet::class);
$timesheet->method('isExported')->willReturn(true);
$timesheet->method('getId')->willReturn(null);
$this->validator->validate($timesheet, new TimesheetExported());
$this->assertNoViolation();
}
public function testDoesNotTriggerWithPermission()
{
$this->validator = $this->createMyValidator(true);