fix boolean filter with null filter value

changelog/entries/unreleased/bug/fixed_boolean_filter_with_null_filter_value.json

@@ -0,0 +1,7 @@
+{
+    "type": "bug",
+    "message": "Fixed boolean filter with null filter value",
+    "issue_number": null,
+    "bullet_points": [],
+    "created_at": "2024-12-13"
+}

web-frontend/modules/database/components/view/ViewFilterTypeBoolean.vue

@@ -13,7 +13,7 @@ export default {
   mixins: [viewFilter],
   computed: {
     copy() {
-      const value = this.filter.value.toString().toLowerCase().trim()
+      const value = (this.filter.value || '').toString().toLowerCase().trim()
       return trueValues.includes(value)
     },
   },

web-frontend/modules/database/viewFilters.js

@@ -2750,6 +2750,9 @@ export class BooleanViewFilterType extends ViewFilterType {
   }
 
   matches(rowValue, filterValue, field, fieldType) {
+    if (filterValue === null) {
+      filterValue = false
+    }
     filterValue = trueValues.includes(
       filterValue.toString().toLowerCase().trim()
     )

web-frontend/test/unit/database/viewFiltersMatch.spec.js

@@ -1,6 +1,7 @@
 import { TestApp } from '@baserow/test/helpers/testApp'
 import moment from '@baserow/modules/core/moment'
 import {
+  BooleanViewFilterType,
   DateAfterDaysAgoViewFilterType,
   DateAfterOrEqualViewFilterType,
   DateAfterTodayViewFilterType,
@@ -1873,6 +1874,44 @@ const formulaUrlFieldFilterNotEqualCases = [
   },
 ]
 
+const booleanFieldTests = [
+  {
+    filterValue: null,
+    rowValue: null,
+    expectedResult: true, // both will evaluate to false
+  },
+  {
+    filterValue: null,
+    rowValue: '',
+    expectedResult: true, // both will evaluate to false
+  },
+  {
+    filterValue: '',
+    rowValue: '',
+    expectedResult: true, // both will evaluate to false
+  },
+  {
+    filterValue: false,
+    rowValue: true,
+    expectedResult: false,
+  },
+  {
+    filterValue: '0',
+    rowValue: '0',
+    expectedResult: true,
+  },
+  {
+    filterValue: '1',
+    rowValue: '0',
+    expectedResult: false,
+  },
+  {
+    filterValue: '1',
+    rowValue: '1',
+    expectedResult: true,
+  },
+]
+
 describe('All Tests', () => {
   let testApp = null
 
@@ -2671,4 +2710,13 @@ describe('All Tests', () => {
     'formulaUrlFieldFilters lenght is lower than test case %j',
     runUrlFormulafieldTest
   )
+
+  test.each(booleanFieldTests)('Boolean filter type tests %j', (values) => {
+    const result = new BooleanViewFilterType().matches(
+      values.rowValue,
+      values.filterValue,
+      {}
+    )
+    expect(result).toBe(values.expectedResult)
+  })
 })